Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.9] fix cluster metric load average order #4403

Open
wants to merge 3 commits into
base: dev-v2.9
Choose a base branch
from
Open

[dev-v2.9] fix cluster metric load average order #4403

wants to merge 3 commits into from

Conversation

skanakal
Copy link
Contributor

@skanakal skanakal commented Sep 9, 2024

Issue:

rancher/rancher#46999

Problem

Solution

re-arrange the queries order to display in the order: 1min, 5min, 15min.

Testing

Engineering Testing

Manual Testing

image

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@skanakal skanakal requested a review from a team as a code owner September 9, 2024 15:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@jbiers jbiers changed the title [Dev v2.9] fix cluster metric load average order [dev-v2.9] fix cluster metric load average order Sep 11, 2024
@skanakal skanakal force-pushed the dev-v2.9-fix-cluster-metric-load-average-order branch from 760531a to b4c390d Compare October 3, 2024 10:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@skanakal skanakal requested a review from mallardduck October 14, 2024 07:19
@skanakal skanakal force-pushed the dev-v2.9-fix-cluster-metric-load-average-order branch from b4c390d to 93e4339 Compare November 29, 2024 04:30
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallardduck mallardduck Awaiting requested review from mallardduck

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skanakal